Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

H-3703: Remove unused data_type_constrains_values_on table #5766

Merged

Conversation

TimDiekmann
Copy link
Member

@TimDiekmann TimDiekmann commented Dec 2, 2024

🌟 What is the purpose of this PR?

When I added support for Custom Data Types in the graph I added two reference tables:

  • data_type_inherits_from
  • data_type_constrains_values_on

The former is used for the allOf. The second one I added in advance because I assumed this is what we’re going to use for anyOf. However, we chose another route here. If we need it we can easily re-add it.

@TimDiekmann TimDiekmann self-assigned this Dec 2, 2024
@github-actions github-actions bot added area/libs Relates to first-party libraries/crates/packages (area) type/eng > backend Owned by the @backend team labels Dec 2, 2024
Copy link

codecov bot commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 21.68%. Comparing base (7d56ea5) to head (d0cebf6).
Report is 30 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5766      +/-   ##
==========================================
- Coverage   21.93%   21.68%   -0.25%     
==========================================
  Files         552      552              
  Lines       18537    18659     +122     
  Branches     2651     2689      +38     
==========================================
- Hits         4066     4047      -19     
- Misses      14429    14570     +141     
  Partials       42       42              
Flag Coverage Δ
apps.hash-ai-worker-ts 1.32% <ø> (-0.01%) ⬇️
apps.hash-api 1.16% <ø> (-0.01%) ⬇️
local.hash-backend-utils 8.80% <ø> (ø)
local.hash-graph-sdk 100.00% <ø> (ø)
local.hash-isomorphic-utils 1.03% <ø> (-0.02%) ⬇️
local.hash-subgraph 24.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TimDiekmann TimDiekmann added this pull request to the merge queue Dec 2, 2024
Merged via the queue into main with commit 6cd1744 Dec 2, 2024
86 of 88 checks passed
@TimDiekmann TimDiekmann deleted the t/h-3703-remove-unused-data_type_constrains_values_on-table branch December 2, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/libs Relates to first-party libraries/crates/packages (area) type/eng > backend Owned by the @backend team
Development

Successfully merging this pull request may close these issues.

2 participants