Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VAULT-32677 - Fix missing client count card in managed clusters #29241

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

emoncuso
Copy link
Contributor

Description

This PR updates checks around the client count card to support clusters run in HCP "managed mode" against Vault Dedicated.

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@emoncuso emoncuso added the ui label Dec 19, 2024
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Dec 19, 2024
Copy link

github-actions bot commented Dec 19, 2024

CI Results:
All Go tests succeeded! ✅

@emoncuso emoncuso added this to the 1.18.4 milestone Dec 19, 2024
@emoncuso emoncuso modified the milestones: 1.18.4, 1.19.0-rc Dec 19, 2024
const { version, isRootNamespace } = this.args;
const { flags, namespace } = this;

// don't show client count if this isn't an enterprise cluster
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are HVD clusters enterprise? I always forget this, but think I remember learning that they are? Just wanted to double check 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants