⚡ Add support for high availability S3 backend #29191
Open
+551
−136
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR prototypes state locking for Vault's s3 backend using Amazon S3’s recently introduced conditional writes feature to implement a locking mechanism.
Currently S3 does not implement the physical.HABackend to support high availability. With S3 Conditional writes, the
if-none-match
header can be applied during the Lock PutObject, which will enforce a remote lock state. In order to introduce this, an upgrade from sdk v1 to sdkv2 was needed. As a result, some work toward #18375 could be achieved due to how the configuration is loaded. This only applies to storage, as additional work would be needed to fully close that issue.Tests
TODO only if you're a HashiCorp employee
backport/
label that matches the desired release branch. Note that in the CE repo, the latest release branch will look likebackport/x.x.x
, but older release branches will bebackport/ent/x.x.x+ent
.of a public function, even if that change is in a CE file, double check that
applying the patch for this PR to the ENT repo and running tests doesn't
break any tests. Sometimes ENT only tests rely on public functions in CE
files.
in the PR description, commit message, or branch name.
description. Also, make sure the changelog is in this PR, not in your ENT PR.