Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Static Role Name Consistency in PostgreSQL Configuration #29138

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

swatibourai0560
Copy link

Role name is inconsistent in "Rootless Configuration and Password Rotation for Static Roles" Section

The role name specified in allowed_roles="my-role" under the section "Rootless Configuration and Password Rotation for Static Roles" should align with the static role name in step #3. Previously, the command incorrectly used "my-static-role"; it should be "my-role" to match the earlier step.

The same role name should also be used when reading the static credentials in step #4

Description

What does this PR do?

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

… role name is consistent.

The role name specified in allowed_roles="my-role" under the section "Rootless Configuration and Password Rotation for Static Roles" should align with the static role name in step hashicorp#3. Previously, the command incorrectly used "my-static-role"; it should be "my-role" to match the earlier step.

The same role name should also be used when reading the static credentials in step hashicorp#4
@swatibourai0560 swatibourai0560 requested a review from a team as a code owner December 10, 2024 12:50
Copy link

hashicorp-cla-app bot commented Dec 10, 2024

CLA assistant check
All committers have signed the CLA.

@swatibourai0560 swatibourai0560 requested a review from a team as a code owner December 10, 2024 12:58
@heatherezell heatherezell added secret/database/postgresql bug Used to indicate a potential bug docs labels Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants