Terraform test: Execute eligible test runs in parallel #36300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsa0x
force-pushed
the
sams/tf-test-run-parallel
branch
from
38f192d to
3f8ae6e
Compare
dsa0x
force-pushed
the
sams/tf-test-run-parallel
branch
from
3f8ae6e to
f2201ea
Compare
dsa0x
force-pushed
the
sams/tf-test-run-parallel
branch
from
f2201ea to
754bc4e
Compare
dsa0x
force-pushed
the
sams/tf-test-run-parallel
branch
2 times, most recently
from
d71ee5e to
6871a7d
Compare
dsa0x
force-pushed
the
sams/tf-test-run-parallel
branch
from
eeeb05b to
e94cd79
Compare
dsa0x
changed the title
dsa0x
force-pushed
the
sams/tf-test-run-parallel
branch
from
e94cd79 to
554af21
Compare
dsa0x
force-pushed
the
sams/tf-test-run-parallel
branch
from
e3dbde7 to
861afba
Compare
dsa0x
force-pushed
the
sams/tf-test-run-parallel
branch
from
85d0528 to
974272d
Compare
dsa0x
force-pushed
the
sams/tf-test-run-parallel
branch
from
36227ed to
9bce19f
Compare
liamcervante
reviewed
Feb 5, 2025
internal/backend/local/test.go
Outdated
Comment on lines
374
to
391
| if runner.Suite.Stopped { | ||
| // Then the test was requested to be stopped, so we just mark each | ||
| // following test as skipped, print the status, and move on. | ||
| run.Status = moduletest.Skip | ||
| runner.Suite.View.Run(run, file, moduletest.Complete, 0) | ||
| continue | ||
| return | ||
| } | ||
|
|
||
| file.Lock() | ||
| if file.Status == moduletest.Error { | ||
| // If the overall test file has errored, we don't keep trying to | ||
| // execute tests. Instead, we mark all remaining run blocks as | ||
| // skipped, print the status, and move on. | ||
| run.Status = moduletest.Skip | ||
| runner.Suite.View.Run(run, file, moduletest.Complete, 0) | ||
| continue | ||
| file.Unlock() | ||
| return | ||
| } | ||
| file.Unlock() |
There was a problem hiding this comment.
should we move this above the .Execute() calls above? Just so we check if we should execute before we do any of the work?
There was a problem hiding this comment.
Sure. It was only okay to do this because most of the execution is still done in this file, but that may change in future, so will move 👍
=> 9555a29
dsa0x
force-pushed
the
sams/tf-test-run-parallel
branch
from
28e93e4 to
74e4d8d
Compare
dsa0x
force-pushed
the
sams/tf-test-run-parallel
branch
from
74e4d8d to
9555a29
Compare
liamcervante
approved these changes
Feb 5, 2025
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #34180
This PR introduces a graph-based execution model into the terraform test framework. With this model, test runs are able to execute in parallel. However, the rules for executing 2 runs in parallel must be fulfilled. Both runs must not share the same state, and there must be no interdependency between them.
The PR also introduces a new "test" block to test files. The block can be used to annotate the file's runs as candidates for parallelism. Each individual run block can however also set this attribute.
For now, the execution of a test run is split between the
Executemethod of the NodeTestRun, and the graph walk callback itself. Eventually, all logic should be moved into theExecutemethod.Target Release
1.11.x
CHANGELOG entry