Fix nodeConfigDefaults on cluster create. #20936
Merged
+76
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[upstream:462421d9d258748a5b6d6091254062fc248fd7f6] Signed-off-by: Modular Magician <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The expansion of
node_pool_defaults.node_config_defaults.insecure_kubelet_readonly_port_enabledshould have a ForceSendFields to allowFALSEvalues to be propagated.Without this "FALSE" values are not included in the request.
This is not an issue in nodePoolAutoConfig, or during updates. ForceSendFields is set in those cases.
An alternative fix is to use expandNodeKubeletConfig function here as well. The server will reject any values other than the readonly port field.
Derived from GoogleCloudPlatform/magic-modules#12664