fix: archive extraction header.Linkname and old dependencies #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dduzgun-security
changed the title
| return false, fmt.Errorf("couldn't find relative path : %w", err) | ||
| } | ||
|
|
||
| if rel != ".." && !(len(rel) >= 3 && rel[:3] == "../") { |
There was a problem hiding this comment.
I think we can remove this condition since the rel will already be cleaned.
There was a problem hiding this comment.
It would be a good idea to copy the validation function the Nomad team worked on and use that to reduce code. https://github.com/hashicorp/nomad/blob/main/helper/escapingfs/escapes.go#L110-L119 maybe under /internal/helper
| return false, fmt.Errorf("couldn't find relative path : %w", err) | ||
| } | ||
|
|
||
| if rel != ".." && !(len(rel) >= 3 && rel[:3] == "../") { |
There was a problem hiding this comment.
Similar to the following comment: https://github.com/hashicorp/go-slug/pull/80/files#r1937639814
dduzgun-security
requested changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to fix the CVEs in below tickets: