Skip to content

Added pull request description #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Added pull request description #31

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions .github/PULL_REQUEST_TEMPLATE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
## Description
<!-- Provide a summary of what the PR does and why it is being submitted. -->

## Testing
<!-- Describe how the changes have been tested. Provide test instructions or details. -->

## External links
<!-- Any related external links can be added here -->

- [JIRA](https://hashicorp.atlassian.net/browse/xxxx)
- [RFC](https://docs.google.com/document/d/xxxx)
- [PRD](https://docs.google.com/document/d/xxxx)
- [Related PR](https://github.com/hashicorp/atlas/pull/xxxx)
- [Documentation](https://github.com/hashicorp/terraform-docs-common/pull/xxxx)
Comment on lines +10 to +14
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason for these link examples?

This is a public repository, so external contributors won't be using Jira, RFCs, or PRDs and it's likely internal contributors won't have 2 of these 3 links depending on the PR request purpose. The bottom two are "randomly selected" pointers, one of which is not a public repo. I am of the opinion these should be removed.

Loading