Multi language support implemented, alert dialogue implemented #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hasancse91
reviewed
May 6, 2022
|
Bhaia,
Apps targeting Android 12 and higher are required to specify an explicit
value for 'android:exported'.
That's why i had to use exported = true.
I tried with exported = false, but that resulted in exception.
I've attached the exception screenshot for exported = false.
…On Fri, May 6, 2022, 3:50 PM Hasan Abdullah ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In android/app/src/main/AndroidManifest.xml
<#30 (comment)>
:
> @@ -8,6 +8,7 @@
***@***.***/ic_launcher">
<activity
android:name=".MainActivity"
+ android:exported="true"
Could you please explain the reason of exported=true?
—
Reply to this email directly, view it on GitHub
<#30 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMW5L4BTMZZ6QFNRU35ZKZTVITTPVANCNFSM5VFA4M2A>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
hasancse91
requested changes
May 12, 2022
There was a problem hiding this comment.
Good work.
Few things need to be better.
- Radio button icon and Language text both should be clickable. Right now only radio icon (circle) is clickable.
- Cancel button's area is very tiny. Make the clickable area as like as Confirm button. Maybe TextButton widget is more appropriate here.
|
Thanks for the feedback bhaia. I'll implement this and give another pull
request
…On Thu, May 12, 2022, 6:55 PM Hasan Abdullah ***@***.***> wrote:
***@***.**** requested changes on this pull request.
Good work.
Few things need to be better.
1. Radio button icon and Language text both should be clickable. Right
now only radio icon (circle) is clickable.
2. Cancel button's area is very tiny. Make the clickable area as like
as Confirm button. Maybe TextButton widget is more appropriate here.
—
Reply to this email directly, view it on GitHub
<#30 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMW5L4AEUKXS4CRY643YYW3VJT5S3ANCNFSM5VFA4M2A>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Just update the code and push at the same branch. After code pushing, |
…p area increase to both Text and button
|
New pull request added: hasancse91:master...AzfarInan:features/multi-language-support |
Our repository has been updated. Could you please pull from master and re-request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why? (ticket link or issue description)
#17
What was done and how?
Integrated multi language support using GetX
Updated Settings UI
Implemented Alert box for language change
Updated localizations
Anything special? (optional)