-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CY] Add template and fix vm #359
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TachunLin Thanks for your review.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified on commit [8585d05] (8585d05)
on newly installed one node harvester.
- The test
Auto setup image from cypress environment
got assertion error
Check Image list: expected '' to equal 200
At: [testcases/image/images.spec.ts:31:50]
It looks like may related to page synchronization of loading latency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified on commit 4a1552d
-
The first image test case
Auto setup image from cypress environment
would failed
cypress can find page contains the image name
-
The first image test case failed would also affect the second test
Create an image with valid image URL
-
The actual image download status on Harvester image page (From another browser)
It looks like the first test case failed would affect the upcoming test execution result.
@n313893254 We did an update to the Cypress version, so you probably want to do a pull from main to your PR. I don't think it should affect your tests very much since it was mostly a change to the config JSON and the version of Cypress (9.3 -> 10.2.0). Please let me know if it caused any issues. |
Also if you change the ISO link in the config to https://mirrors.bfsu.edu.cn/opensuse/distribution/leap/15.3/iso/openSUSE-Leap-15.3-3-NET-x86_64-Media.iso you will probably get less timeouts since it's only 147MB instead of 4GB. I reran some of the tests that way and it fixed a lot of the timeout based problems. |
@TachunLin, Thanks for your review.
|
@noahgildersleeve . Thanks for your review. Delete VM will change the image resource version. Per dashboard code fix the 409 conflicts. |
@noahgildersleeve Thank you. Fixed and there have two changes:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TachunLin I think you need to approve the changes before this PR can be merged. |
Thanks @noahgildersleeve, really appreciated for checking these tests. |
Changes: