-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docs] update terraform related doc (2261 and new 2957) #1744
base: main
Are you sure you want to change the base?
Conversation
} | ||
``` | ||
1. execute `terraform apply -auto-approve` | ||
1. Login to dashboard then navigate to Networks/Cluster Networks, cluster network `cnet-003710` should be created, vlanconfig `cnet-003710-eno50` should be the memeber in the cluster network |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
member?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah it's a typo, fixed.
@@ -4,6 +4,7 @@ title: Terraform import VLAN | |||
|
|||
* Related issues: [#2261](https://github.com/harvester/harvester/issues/2261) [FEATURE] enhance terraform network to not pruge route_cidr and route_gateway | |||
|
|||
** Harvester Version less than `v1.0.3`** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider Harvester Version <= v1.0.3
to align with v1.1.0
one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure about the last test step.
Otherwise LGTM.
1. execute `terraform apply -auto-approve` | ||
1. Login to dashboard then navigate to Networks/Cluster Networks, cluster network `cnet-003710` should be created, vlanconfig `cnet-003710-eno50` should be the member in the cluster network | ||
1. Navigate to Networks/VM Networks, VM Network `tf_vmnetwork` should be created | ||
1. Execute `terraform apply` again and many more times |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this step necessary and what is the expected result?
Which issue(s) this PR fixes:
Issue #573
What this PR does / why we need it:
v1.0.3
v1.1.0
Special notes for your reviewer:
harvester_storageclass
as it is not related to network.Additional documentation or context
we already implemented cluster network related test cases in #979