Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 1568 Fixing S3 Connection Building #1580

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix: 1568 Fixing S3 Connection Building #1580

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions harvester_e2e_tests/integrations/test_4_vm_backup_restore.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,8 @@ def config_backup_target(api_client, conflict_retries, backup_config, wait_timeo
f'Failed to update backup target to {backup_type} with {config}\n'
f"API Status({code}): {data}"
)
# sleeping to allow longhorn secret to be built on Harvester side
sleep(5)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have any way of checking the secret existence? Can we check that in a loop with some sleep?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we loop through checking the status of the backup target by looping through something like api_client.settings.backup_target_test_connection? Will that return true if the secret isn't there?


yield spec

Expand Down