fix/improve backward/forward compatibility for VM Backup and Restore#731
Merged
WebberHuang1118 merged 1 commit intoharvester:mainfrom Mar 28, 2025
Merged
Conversation
WebberHuang1118
force-pushed
the
issue-7738
branch
from
c3eccb5 to
88f4b2c
Compare
|
ihcsim
reviewed
Mar 21, 2025
Contributor
ihcsim
left a comment
ihcsim
left a comment
There was a problem hiding this comment.
I think we also need an upgrade note for this. For some users, this can be a big change.
In the upgrade note, I recommend we describe:
- Affected criteria: AIUI, only 1.3 and 1.4 VMs with 3rd party storage non-root disks
- Why we introduced this change: Backup is not a CSI standard. Hence, remote copies were never created. We need to ensure backup/restore data consistency and integrity which captures the complete state of the VMs.
- What are the workarounds: If this is not possible with Harvester, can we recommend external tools, projects etc.?
WebberHuang1118
changed the title
WebberHuang1118
force-pushed
the
issue-7738
branch
2 times, most recently
from
d23ed6e to
fbe9b00
Compare
Member
Author
Contributor
|
@WebberHuang1118 I'm ok with doing it in another ticket. Whatever alternative approaches we recommend, it should just be reasonably brief like, "use X and refers to documentation at <href>", not an elaborated documentation. |
bk201
previously approved these changes
Mar 26, 2025
asettle
reviewed
Mar 26, 2025
asettle
reviewed
Mar 26, 2025
asettle
suggested changes
Mar 26, 2025
Contributor
asettle
left a comment
asettle
left a comment
There was a problem hiding this comment.
I've provided some edits to make it clearer and more concise, but otherwise, LGTM. Please apply to all the documents, not just the first one.
Contributor
100% agree. |
ihcsim
previously approved these changes
Mar 26, 2025
versioned_docs/version-v1.4/advanced/addons/lvm-local-storage.md
Outdated
Show resolved
Hide resolved
versioned_docs/version-v1.4/advanced/addons/lvm-local-storage.md
Outdated
Show resolved
Hide resolved
versioned_docs/version-v1.4/advanced/addons/lvm-local-storage.md
Outdated
Show resolved
Hide resolved
WebberHuang1118
dismissed stale reviews from ihcsim, innobead, and bk201
via
36af80e
WebberHuang1118
force-pushed
the
issue-7738
branch
from
df4a77c to
56f721e
Compare
WebberHuang1118
requested review from
asettle,
bk201,
ihcsim,
innobead and
jillian-maroket
WebberHuang1118
force-pushed
the
issue-7738
branch
2 times, most recently
from
61a14c9 to
cc56988
Compare
Contributor
jillian-maroket
left a comment
jillian-maroket
left a comment
There was a problem hiding this comment.
I reviewed the new text.
WebberHuang1118
force-pushed
the
issue-7738
branch
from
568c97d to
f30f09e
Compare
Member
Author
Updated per suggestions, thanks. |
WebberHuang1118
force-pushed
the
issue-7738
branch
from
f30f09e to
d4ba37c
Compare
Signed-off-by: Webber Huang <webber.huang@suse.com> Co-authored-by: Ivan Sim <1330522+ihcsim@users.noreply.github.com> Co-authored-by: Alexandra Settle <asettle@suse.com> Co-authored-by: Jillian Maroket <67180770+jillian-maroket@users.noreply.github.com>
WebberHuang1118
force-pushed
the
issue-7738
branch
from
d4ba37c to
ad3f3f2
Compare
bk201
approved these changes
Mar 28, 2025
jillian-maroket
approved these changes
Mar 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue harvester/harvester#7738