Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HARVESTER: disable enter key #878

Merged
merged 1 commit into from
Jul 27, 2023

Conversation

WuJun2016
Copy link

@WuJun2016 WuJun2016 commented Jul 27, 2023

Summary

PR Checklist

- Is this a multi-tenancy feature/bug?
- [ ] Yes, the relevant RBAC changes are at:

- Do we need to backport changes to the old Rancher UI, such as RKE1?
- [ ] Yes, the relevant PR is at:

- Are backend engineers aware of UI changes?
- [ ] Yes, the backend owner is:

Fixes #

Occurred changes and/or fixed issues

Technical notes summary

Areas or cases that should be tested

  1. Mouse to select any row of resources
  2. press the Enter key (if the resource has a detail page, then it should go to the detail page correctly, otherwise nothing will be done)

Areas which could experience regressions

Screenshot/Video

Copy link

@DaiYuzeng DaiYuzeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@DaiYuzeng DaiYuzeng merged commit 11de217 into harvester:master Jul 27, 2023
9 checks passed
@DaiYuzeng
Copy link

@mergify backport release-harvester-v1.2

@mergify
Copy link

mergify bot commented Jul 27, 2023

backport release-harvester-v1.2

✅ Backports have been created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants