Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HARVESTER: Polish seeder state.message && Fix IP pool selector is null #835

Merged
merged 2 commits into from
Jul 4, 2023

Conversation

n313893254
Copy link

@n313893254 n313893254 commented Jul 3, 2023

Summary

PR Checklist

- Is this a multi-tenancy feature/bug?
- [ ] Yes, the relevant RBAC changes are at:

- Do we need to backport changes to the old Rancher UI, such as RKE1?
- [ ] Yes, the relevant PR is at:

- Are backend engineers aware of UI changes?
- [ ] Yes, the backend owner is:

Fixes #

  • Polish seeder state.message
  • Fix the IP pool selector is null
  • Fix IP pool edit as YAML without status

Occurred changes and/or fixed issues

Technical notes summary

  • Update seeder state for API change
  • Fix UI render when IP pool selector is null

Areas or cases that should be tested

Seeder Test Plan

  • Enable out-of-band Access with an invalid address or secret
  • Check the banner in the host list/edit/detail page

IP pool test plan

  • Create an IP pool
  • Edit YAML and delete the selector
  • Check IP pool create/edit

Areas which could experience regressions

Screenshot/Video

image
image

Copy link

@WuJun2016 WuJun2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgmt, thanks

@WuJun2016 WuJun2016 merged commit 52b7a5d into harvester:master Jul 4, 2023
@WuJun2016
Copy link

@mergify backport release-harvester-v1.2

@mergify
Copy link

mergify bot commented Jul 4, 2023

backport release-harvester-v1.2

✅ Backports have been created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants