Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HARVESTER: improve exhibition of addon's status #833

Merged
merged 1 commit into from
Jul 4, 2023

Conversation

DaiYuzeng
Copy link

@DaiYuzeng DaiYuzeng commented Jul 3, 2023

Summary

PR Checklist

  • Is this a multi-tenancy feature/bug?
    • Yes, the relevant RBAC changes are at:
  • Do we need to backport changes to the old Rancher UI, such as RKE1?
    • Yes, the relevant PR is at:
  • Are backend engineers aware of UI changes?
    • Yes, the backend owner is:

Occurred changes and/or fixed issues

We want to improve the exhibitions of addon's status.

Technical notes summary

Areas or cases that should be tested

  1. Swtich enabling/disabling status of addon quickly should be failed and you should see the error message on the top-right corner.
  2. When enabling/disabling/updating if you edit the configurations of addon and then save, save should be failed and the error message should be also displayed.

Areas which could experience regressions

Screenshot/Video

image

image

Copy link

@WuJun2016 WuJun2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

@WuJun2016 WuJun2016 merged commit e792bad into harvester:master Jul 4, 2023
@WuJun2016
Copy link

@mergify backport release-harvester-v1.2

@mergify
Copy link

mergify bot commented Jul 4, 2023

backport release-harvester-v1.2

✅ Backports have been created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants