Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WORKAROUND] fix create namespace page broken on rancher 2.8.x #1224

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

a110605
Copy link
Collaborator

@a110605 a110605 commented Nov 7, 2024

Summary

shell/models/steve-schema.ts was added in #1208 which was not existed on Rancher v2.8 shell.

This PR add workaround if condition to avoid fall into below two throw new Error.

PR Checklist

  • Is this a multi-tenancy feature/bug?
    • Yes, the relevant RBAC changes are at:
  • Do we need to backport changes to the old Rancher UI, such as RKE1?
    • Yes, the relevant PR is at:
  • Are backend engineers aware of UI changes?
    • Yes, the backend owner is:

Related Issue #
harvester/harvester#6953

Screenshot/Video

image

@a110605
Copy link
Collaborator Author

a110605 commented Nov 7, 2024

Hi @torchiaf ,

shell/models/steve-schema.ts is bundled to rancher shell when importing harvester v1.4.0 on Rancher v2.8.x.
See you have better solution to overcome this problem.

Copy link
Collaborator

@torchiaf torchiaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@a110605 a110605 added the Backport to v1.4 Backport PR target v1.4 label Nov 7, 2024
@a110605
Copy link
Collaborator Author

a110605 commented Nov 7, 2024

Re-test work well on Rancher v2.9.2.

Screenshot 2024-11-07 at 5 33 00 PM

@a110605 a110605 merged commit db2d462 into harvester:master Nov 7, 2024
10 checks passed
torchiaf added a commit that referenced this pull request Nov 7, 2024
…v1.4/pr-1224

[WORKAROUND] fix create namespace page broken on rancher 2.8.x (backport #1224)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backport to v1.4 Backport PR target v1.4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants