-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add provisioned vGpus in VM's devices list. #1154
Add provisioned vGpus in VM's devices list. #1154
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code change is good.
This pull request is now in conflict. Could you fix it @torchiaf? 🙏 |
Signed-off-by: Francesco Torchia <[email protected]>
8c03fee
to
ca6ff46
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@mergify backport release-harvester-v1.4 release-harvester-v1.3 |
✅ Backports have been created
|
…v1.3/pr-1154 Add provisioned vGpus in VM's devices list. (backport #1154)
…v1.4/pr-1154 Add provisioned vGpus in VM's devices list. (backport #1154)
Summary
It adds the vGpu devices tracked in VM's annotation to the VM's vGpu list.
Those vGpus are provisioned by Harvester when creating new clusters from Rancher.
PR Checklist
Related Harvester Issue harvester/harvester#6638
Blocks rancher#11399
Occurred changes and/or fixed issues
Technical notes summary
Areas or cases that should be tested
Create
Edit/Remove
Edit/Remove in Harvester
Areas which could experience regressions
Screenshot/Video