-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add volume and image encryption feature #1151
Conversation
A thought just popped into my head. Do we need to display locker icon in the VM page if some VMs use encrypted image or volumes? It might be a useful information for users? cc @bk201 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one question, should we clear the secret name when we select different secret namespace each time?
demo-01.mov
Good finding. It should clean the secret when chaning namespace. |
Per discussion with @Yu-Jack , add lock icon in VM list page and show the tooltip with
See in vm-lock.webm |
117cb41
to
b5ce7d8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
pkg/harvester/edit/harvesterhci.io.storage/provisioners/driver.longhorn.io.vue
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
4f9bab7
to
593f957
Compare
Show encrytion field in vm detail volume tab and render lock in
@jillian-maroket, could you give advice for above 2 messages ? thanks. vm_lock_icon.webm |
pkg/harvester/detail/harvesterhci.io.virtualmachineimage/index.vue
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good, just a few minor CRs and question below (Maybe something we can add in the next release as improvements).
@Yu-Jack @a110605 I have a few questions:
- Should we add 'Encrypt' / 'Decrypt' actions in the image list ?
- Would it make sense to have a reference to the image that is being decrypted / encrypted, in the new image?
I think these are "nice to have" improvements at this moment. Maybe we could put them into Backlog to next release? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. BTW, there is a failed build about check-plugins-build
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
presentation lgtm, thanks!
Wait for fixed PR #1160 merge first. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed the "partial" tooltip.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: andy.lee <[email protected]>
Signed-off-by: andy.lee <[email protected]>
Signed-off-by: andy.lee <[email protected]>
Signed-off-by: andy.lee <[email protected]>
Signed-off-by: andy.lee <[email protected]>
Summary
PR Checklist
Related Issue #
harvester/harvester#6493
Screenshot/Video
Create Storage class with Secret
create_sc.webm
Encrypted & decrypt Image
image_en:decrypt.webm
Encrypt volume
volume_encypt.webm