Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the UX of non-migratable VMs in node maintenance mode #1092

Merged
merged 4 commits into from
Aug 7, 2024
Merged

Improve the UX of non-migratable VMs in node maintenance mode #1092

merged 4 commits into from
Aug 7, 2024

Conversation

torchiaf
Copy link
Collaborator

@torchiaf torchiaf commented Aug 6, 2024 •
edited by a110605
Loading

Summary

PR Checklist

  • Is this a multi-tenancy feature/bug?
    • Yes, the relevant RBAC changes are at:
  • Do we need to backport changes to the old Rancher UI, such as RKE1?
    • Yes, the relevant PR is at:
  • Are backend engineers aware of UI changes?
    • Yes, the backend owner is:

Related Issue

Occurred changes and/or fixed issues

Technical notes summary

Areas or cases that should be tested

Areas which could experience regressions

Screenshot/Video

image

image

image

@torchiaf torchiaf requested a review from a110605 August 6, 2024 16:27
@bk201 bk201 mentioned this pull request Aug 7, 2024
Closed
@torchiaf
Fix lint and messages
9cf398b 
Signed-off-by: Francesco Torchia <[email protected]>
@torchiaf torchiaf requested a review from a110605 August 7, 2024 10:08
@torchiaf
Add errors uppercase
33b9336 
Signed-off-by: Francesco Torchia <[email protected]>
@torchiaf
Copy link
Collaborator Author

torchiaf commented Aug 7, 2024

@mergify backport release-harvester-v1.3

@mergify Mergify
Copy link

mergify bot commented Aug 7, 2024 •
edited
Loading

backport release-harvester-v1.3

✅ Backports have been created

@torchiaf
Copy link
Collaborator Author

torchiaf commented Aug 7, 2024

@mergify backport release-harvester-v1.4

@mergify Mergify
Copy link

mergify bot commented Aug 7, 2024 •
edited
Loading

backport release-harvester-v1.4

✅ Backports have been created

a110605
a110605 approved these changes Aug 7, 2024
View reviewed changes
Copy link
Collaborator

@a110605 a110605 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test locally is good.
image

@a110605 a110605 merged commit 9328aa8 into harvester:master Aug 7, 2024
7 checks passed
This was referenced Aug 7, 2024
Merged
Merged
torchiaf added a commit that referenced this pull request Aug 7, 2024
@torchiaf
Merge pull request #1094 from harvester/mergify/bp/release-harvester-…
6866f21 
…v1.3/pr-1092

Improve the UX of non-migratable VMs in node maintenance mode (backport #1092)
torchiaf added a commit that referenced this pull request Aug 7, 2024
@torchiaf
Merge pull request #1095 from harvester/mergify/bp/release-harvester-…
37d9a2a 
…v1.4/pr-1092

Improve the UX of non-migratable VMs in node maintenance mode (backport #1092)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a110605 a110605 a110605 approved these changes

@ibrokethecloud ibrokethecloud Awaiting requested review from ibrokethecloud

Assignees

@torchiaf torchiaf

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@torchiaf @a110605