Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow user to enable / disable node disk scheduling #1087

Merged
merged 1 commit into from
Aug 5, 2024
Merged

Allow user to enable / disable node disk scheduling #1087

merged 1 commit into from
Aug 5, 2024

Conversation

a110605
Copy link
Collaborator

@a110605 a110605 commented Jul 30, 2024 •
edited
Loading

Summary

  • Allow user to enable / disable node disk scheduling in node page -> Edit Config -> storage tab.
  • View the disk scheduling in node detail page storage tab.

PR Checklist

  • Is this a multi-tenancy feature/bug?
    • Yes, the relevant RBAC changes are at:
  • Do we need to backport changes to the old Rancher UI, such as RKE1?
    • Yes, the relevant PR is at:
  • Are backend engineers aware of UI changes?

Related Issue #
harvester/harvester#5836

Areas which could experience regressions

This PR should be backport to v1.4 and v1.3

Screenshot/Video

Screen.Recording.2024-07-31.at.2.47.45.PM.mov

@a110605 a110605 self-assigned this Jul 30, 2024
@a110605 a110605 force-pushed the issue-5836 branch 2 times, most recently from 8d5426e to 164106a Compare July 31, 2024 06:31
@a110605 a110605 marked this pull request as ready for review July 31, 2024 06:51
Vicente-Cheng
Vicente-Cheng approved these changes Aug 2, 2024
View reviewed changes
Copy link

@Vicente-Cheng Vicente-Cheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

torchiaf
torchiaf approved these changes Aug 4, 2024
View reviewed changes
Copy link
Collaborator

@torchiaf torchiaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@a110605 a110605 merged commit f4d98cd into harvester:master Aug 5, 2024
9 checks passed
@a110605
Copy link
Collaborator Author

a110605 commented Aug 5, 2024 •
edited
Loading

@mergify backport release-harvester-v1.4

@mergify Mergify
Copy link

mergify bot commented Aug 5, 2024 •
edited
Loading

backport release-harvester-v1.4

✅ Backports have been created

@mergify mergify bot mentioned this pull request Aug 5, 2024
Merged
3 tasks
@a110605
Copy link
Collaborator Author

a110605 commented Aug 5, 2024

@mergify backport release-harvester-v1.3

@mergify Mergify
Copy link

mergify bot commented Aug 5, 2024 •
edited
Loading

backport release-harvester-v1.3

✅ Backports have been created

@mergify mergify bot mentioned this pull request Aug 5, 2024
Merged
3 tasks
This was referenced Aug 6, 2024
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@torchiaf torchiaf torchiaf approved these changes

@Vicente-Cheng Vicente-Cheng Vicente-Cheng approved these changes

Assignees

@a110605 a110605

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@a110605 @Vicente-Cheng @torchiaf