Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support subqueries in FROM and JOIN. #250

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ChickenProp
Copy link

I may be missing something, but from my simple experiments so far this seems to work.

If you'd be amenable to adding this, I'll be happy to add tests and change documentation as necessary.

@harelba
Copy link
Owner

harelba commented Mar 27, 2021

Hi @ChickenProp ! thanks for the PR.

I'm in the middle of a huge change inside q's code which should provide a large improvement. I'll take a deeper look into it when i'm done.

@ChickenProp
Copy link
Author

@harelba gentle ping :) I see there's been some big changes, is this something you're in a position to look at now? (I confess I haven't actually checked if this still works.)

@harelba
Copy link
Owner

harelba commented Mar 23, 2022

thanks for the ping @ChickenProp

Indeed, I've released a very large change, although it doesn't include changes to the query parsing itself.

I was planning a major change in query parsing, but it's a very big task, and most use-cases are covered by the current "parsing". I'll take a look to see if I can introduce a smaller change that will accommodate this use-case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants