Skip to content

Commit

Permalink
Remove OR operator from the benchmark job (safe-global#736)
Browse files Browse the repository at this point in the history
This PR:
- Fix the benchmark CI job to prebent regressions like
safe-global#735. It is
fixed by removing the OR operator because if a benchmark failed, it only
outputted a message but didn't return a non-zero exit code.
- Also bumps the `0.8.x` compiler version to the latest one (0.8.24)
  • Loading branch information
mmv08 authored Feb 8, 2024
1 parent 3da1415 commit 3b4c992
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -68,9 +68,9 @@ jobs:
strategy:
fail-fast: false
matrix:
solidity: ["0.7.6", "0.8.19"]
solidity: ["0.7.6", "0.8.24"]
include:
- solidity: "0.8.19"
- solidity: "0.8.24"
settings: '{"viaIR":true,"optimizer":{"enabled":true,"runs":1000000}}'
env:
SOLIDITY_VERSION: ${{ matrix.solidity }}
Expand All @@ -81,4 +81,4 @@ jobs:
with:
node-version: ${{ env.NODE_VERSION }}
cache: "npm"
- run: (npm ci && npm run build && npx hardhat codesize --contractname Safe && npm run benchmark) || echo "Benchmark failed"
- run: npm ci && npm run build && npx hardhat codesize --contractname Safe && npm run benchmark

0 comments on commit 3b4c992

Please sign in to comment.