Code cleanup #161
Merged
Code cleanup #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fregante
commented
Sep 27, 2024
| export let optionsUrl; | ||
| export let icons; // Optional | ||
| export let icons = undefined; // eslint-disable-line no-undef-init -- Optional svelte property |
There was a problem hiding this comment.
eslint autofixed this away from #160
| @@ -0,0 +1,20 @@ | |||
| export default function pickBestIcon(icons, size = 16) { | |||
There was a problem hiding this comment.
I had to rewrite this function because I had messed up and never checked. Tests FTW
| } | ||
|
|
||
| // If it's not available (e.g. requested 32, available only 16), get the largest one | ||
| return smallestToLargest.at(-1).url; |
There was a problem hiding this comment.
The main change is that it will now never pick the fallback if any icons exist.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.