Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated breaking changes to Handsontable 0.34+ as mentioned issue #219 #221

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

churchs19
Copy link

Updated breaking changes to Handsontable 0.34+ as mentioned in #219 (comment).

Removed irrelevant tests due to Copy/Paste refactoring in Handsontable 0.33+

…ntable#219 (comment).

Removed irrelevant tests due to Copy/Paste refactoring in Handsontable 0.33+
@veneliniliev
Copy link

please merge this pull request!

@kangzheTW
Copy link

@AMBudnik Do you have the plan to update the underlying handsontable to a version newer than 0.28?

@AMBudnik
Copy link

AMBudnik commented Mar 1, 2018

Sorry but I do not have any news on ngHandsontable. We are switched our resources to update the Angular 2+ wrapper

@vkirienko
Copy link

Hi,

How come you just bumped version with two changes to support v8 when this is broken for more that two years? And btw line 33 should be fixed as following:

var row = this.instance.getSelectedLast()[0];

@AMBudnik
Copy link

AMBudnik commented Sep 9, 2020

Hi @vkirienko that issue was out of the scope for that operation.

@vkirienko
Copy link

vkirienko commented Sep 9, 2020 via email

@AMBudnik
Copy link

Hi @vkirienko we made that update to support a crucial project. Its requirements are basic but as we've made a lot of beneficial changes in v8.0.0 of Handsontable we wanted to use them. We do not force anyone to update and we always encouraged to fork the project by keeping this repository under MIT license.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants