Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support displaying a list of RSS sources in plugin details #41

Merged
merged 2 commits into from
Dec 6, 2024
Merged

feat: support displaying a list of RSS sources in plugin details #41

merged 2 commits into from
Dec 6, 2024

Conversation

guqing
Copy link
Member

@guqing guqing commented Dec 5, 2024

What this PR does?

支持在插件详情页面展示订阅源信息

GET http://localhost:8090/apis/api.feed.halo.run/v1alpha1/rss-sources

/kind feature

支持在插件详情页面展示订阅源信息

@f2c-ci-robot f2c-ci-robot bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels Dec 5, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from JohnNiang and ruibaby December 5, 2024 09:39
@f2c-ci-robot f2c-ci-robot
Copy link

f2c-ci-robot bot commented Dec 5, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from guqing. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@guqing guqing force-pushed the feature/rss-source-view branch 2 times, most recently from a0220ed to 5b9d4e6 Compare December 5, 2024 09:52
@ruibaby
Copy link
Member

ruibaby commented Dec 5, 2024

这里不会显示默认的 /rss.xml 吗？

image

@guqing
Copy link
Member Author

guqing commented Dec 5, 2024

这里不会显示默认的 /rss.xml 吗？

image

不会 默认的是单独写的的 我可以追加在前面

@guqing guqing force-pushed the feature/rss-source-view branch from 72b1088 to 110f467 Compare December 6, 2024 03:22
@guqing guqing added the tide/merge-method-merge Denotes a PR that should use a standard merge by tide when it merges. label Dec 6, 2024
@guqing guqing marked this pull request as ready for review December 6, 2024 03:23
@f2c-ci-robot f2c-ci-robot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 6, 2024
@f2c-ci-robot f2c-ci-robot bot requested a review from wan92hen December 6, 2024 03:23
@guqing guqing merged commit d55dd55 into main Dec 6, 2024
1 of 2 checks passed
@guqing guqing deleted the feature/rss-source-view branch December 6, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnNiang JohnNiang Awaiting requested review from JohnNiang

@ruibaby ruibaby Awaiting requested review from ruibaby

@wan92hen wan92hen Awaiting requested review from wan92hen

Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. tide/merge-method-merge Denotes a PR that should use a standard merge by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guqing @ruibaby