Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent undefined key name when creating Secret #6964

Merged
merged 2 commits into from
Oct 29, 2024

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Oct 29, 2024

What type of PR is this?

/area ui
/kind bug
/milestone 2.20.x

What this PR does / why we need it:

修复使用 Secret 输入框创建 Secret 时,stringData 的 key 可能为 undefined 的问题。

Which issue(s) this PR fixes:

See halo-sigs/plugin-alist#23 (comment) for more

Special notes for your reviewer:

Does this PR introduce a user-facing change?

修复使用 Secret 输入框创建 Secret 时,stringData 的 key 可能为 undefined 的问题。

@f2c-ci-robot f2c-ci-robot bot added area/ui Issues or PRs related to the Halo UI release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Oct 29, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.20.x milestone Oct 29, 2024
@f2c-ci-robot f2c-ci-robot bot requested a review from guqing October 29, 2024 08:26
@f2c-ci-robot f2c-ci-robot bot added the kind/bug Categorizes issue or PR as related to a bug. label Oct 29, 2024
@f2c-ci-robot f2c-ci-robot bot requested a review from JohnNiang October 29, 2024 08:26
@JohnNiang
Copy link
Member

@ruibaby
Copy link
Member Author

ruibaby commented Oct 29, 2024

Copy link

sonarcloud bot commented Oct 29, 2024

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.25%. Comparing base (eff73dc) to head (90331fc).
Report is 42 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6964      +/-   ##
============================================
+ Coverage     56.99%   57.25%   +0.25%     
- Complexity     3999     4006       +7     
============================================
  Files           714      712       -2     
  Lines         24110    24123      +13     
  Branches       1585     1588       +3     
============================================
+ Hits          13742    13811      +69     
+ Misses         9756     9699      -57     
- Partials        612      613       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works very well.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Oct 29, 2024
Copy link

f2c-ci-robot bot commented Oct 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 29, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit fdc90af into halo-dev:main Oct 29, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ui Issues or PRs related to the Halo UI kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants