-
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: prevent undefined key name when creating Secret #6964
Conversation
Signed-off-by: Ryan Wang <[email protected]>
fixed |
Quality Gate passedIssues Measures |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6964 +/- ##
============================================
+ Coverage 56.99% 57.25% +0.25%
- Complexity 3999 4006 +7
============================================
Files 714 712 -2
Lines 24110 24123 +13
Branches 1585 1588 +3
============================================
+ Hits 13742 13811 +69
+ Misses 9756 9699 -57
- Partials 612 613 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works very well.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnNiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/area ui
/kind bug
/milestone 2.20.x
What this PR does / why we need it:
修复使用 Secret 输入框创建 Secret 时,stringData 的 key 可能为 undefined 的问题。
Which issue(s) this PR fixes:
See halo-sigs/plugin-alist#23 (comment) for more
Special notes for your reviewer:
Does this PR introduce a user-facing change?