Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Add autocorrections, refactor check_for_updates and data structures #45

Draft
wants to merge 62 commits into
base: master
Choose a base branch
from
Draft

WIP: Add autocorrections, refactor check_for_updates and data structures #45

wants to merge 62 commits into from

Conversation

d33tah
Copy link
Member

@d33tah d33tah commented Nov 18, 2021 •
edited
Loading

  • run this on Hakierspejs's mail accounts and check the behavior of autocorrections
  • fix regression: default value for notify_overdue_no_earlier_than=`` while it should be null
  • add a unit / system test
  • autocategorize autocorrections (?)
  • so far the essence of test_main hadn't changed at all
  • get rid of most of debug messages
  • check whether the day before or after when autocorrections is happening isn't also a public holiday (remember about the end/beginning of year edge case!)
  • decouple dues.yml from due_settings.yml

@d33tah d33tah marked this pull request as draft November 18, 2021 14:06
d33tah and others added 13 commits November 18, 2021 14:07
@d33tah d33tah changed the title WIP: Add autocorrections, refactor check_for_updates. WIP: Add autocorrections, refactor check_for_updates and data structures Nov 19, 2021
d33tah and others added 14 commits November 20, 2021 18:51
@d33tah
Fix all sender/recipient/expense counting bugs in autocorrections code.
744b951
@d33tah
Fix bug in list_expenses() resulting in passing all of the transfers.
bff75a8
@d33tah
Remove code related to counting d33tah's dues.
b5ceb74 
This is now the job of autocorrections.
@d33tah @actions-user
Autoupdate code coverage stats
fdbc3c7
@d33tah
Experiment: Remove the concept of manual corrections.
4249815
@d33tah @actions-user
Autoupdate code coverage stats
5e5ce1e
@d33tah
Fix the calculation of dues_num_subscribers.
61aa354
@d33tah @actions-user
Autoupdate code coverage stats
b9ade93
@d33tah
Introduce date_acceptable_for_autocorrection as a workaround to a quirk.
4091489
@d33tah @actions-user
Autoupdate code coverage stats
8d60d93
@d33tah
Add a way to specify log_level in the configuration.
1ba93c5
@d33tah @actions-user
Autoupdate code coverage stats
bea9a31
@d33tah
Set loglevel of almost all messages from bookkeeping.py to DEBUG.
b4b4299
@d33tah @actions-user
Autoupdate code coverage stats
363fb86
d33tah and others added 30 commits December 9, 2021 16:39
@d33tah
Bugfix: when looking for a related e-mail, compare anonymized values.
376e53c
@d33tah @actions-user
Autoupdate code coverage stats
f231d58
@d33tah
Run notify_about_overdues every 60 seconds.
c793438
@d33tah
In notify_about_overdues, compare sender_acc_no, not recipient_acc_no.
3a96da6
@d33tah
current_report_builder: operate on "periods", not "months".
5615f1b 
Currently it's a month anyway, but this change will be relevant soon.
@d33tah
Fix broken tests.
5a74e26
@d33tah
homepage_updater: replace "monthly" with "by_period".
1f49bf9
@d33tah @actions-user
Autoupdate code coverage stats
db766b0
@d33tah
Add a layer of indirection to PERIOD_TYPE, which is currently hardcoded.
6d013db
@d33tah
When calculating periodic balance, take period type into account.
03127c5
@d33tah
Calculate more than one period types.
5112883
@d33tah @actions-user
Autoupdate code coverage stats
5cd494d
@d33tah
Fix type annotations.
db2a2fe
@d33tah @actions-user
Autoupdate code coverage stats
de9319d
@d33tah
Merge pull request #48 from hakierspejs/periodic_reporting
fbbb7ac
@d33tah
Run overdue checks every hour, not 60 seconds.
472f6ad
@d33tah @actions-user
Autoupdate code coverage stats
46f2154
@d33tah
Bugfix: overdue messages sometimes sent many times.
0027601
@d33tah @actions-user
Autoupdate code coverage stats
41b9cdb
@d33tah
Make it possible to duplicate category assignments.
634c4ac
@d33tah
Fix style: "formatting a regular string which could be a f-string"
48a7309
@d33tah @actions-user
Autoupdate code coverage stats
36371e8
@d33tah
Fix type annotations.
6860c3c
@d33tah @actions-user
Autoupdate code coverage stats
ecfb751
@d33tah
Fix the overdue message.
836200f
@d33tah @actions-user
Autoupdate code coverage stats
1ff477c
@d33tah
Merge branch 'master' into autocorrect_based_on_reported_balance
9aac3bb 
 Conflicts:
	docs/htmlcov/status.json
@d33tah @actions-user
Autoupdate code coverage stats
1cec8b9
@d33tah
Pin sqlalchemy to latest 1.4.x version version.
b0f06ef 
This is because I was getting errors while instantiating model.
@d33tah @actions-user
Autoupdate code coverage stats
e1f2d1b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@d33tah