2-9-31 dev #400
Merged
2-9-31 dev #400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
henry9610
commented
Nov 11, 2024
henry9610
commented
- fix incorrect image rotation when displaying occasionally.
- fix switch to another app while viewing a PDF and then return, app will restart.
henry9610
force-pushed
the
2-9-31-dev
branch
2 times, most recently
from
df52428
to
cb24ac5
Compare
lilthree
reviewed
Nov 11, 2024
Pod/Classes/Utils.m
Outdated
|
|
||
| + (UIImage *)reSizeImage:(UIImage *)image toSquare:(float)length { | ||
| CGSize newSize = CGSizeMake(length, length); | ||
| if (@available(iOS 10.0, *)) { |
There was a problem hiding this comment.
现在app支持的最低版本是iOS11，可以不需要判断版本，另外UIGraphicsImageRenderer这个方法在iOS17之后的系统上会出现size的宽高为零时的崩溃，最好是加上对length的判断，防止后面调用时出现问题。
henry9610
force-pushed
the
2-9-31-dev
branch
from
f676367
to
ffe3051
Compare
henry9610
force-pushed
the
2-9-31-dev
branch
from
ffe3051
to
b2d33ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.