Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rappdirs support #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

rappdirs support #3

wants to merge 1 commit into from

Conversation

hrbrmstr
Copy link

Documentation and functionality change to get_miniconda_path() to look first in the R_MINICONDA_PATH then does the rappdirs check and finally ~/rminiconda check (both for existence, then tries to create if not there and then tests if writeable).

I need to test this when I get bandwidth (hotel wifi is as bad as Stanford's guest network) but wanted to get it submitted before 🛩.

@hafen
Copy link
Owner

hafen commented Sep 20, 2019

Thanks! It looks like the linux and windows CI tests passed. Testing locally on MacOS, I get an error due to the space in "Application Support" when miniconda installs. Probably need to escape the space in the path when running the installer (https://github.com/hrbrmstr/rminiconda/blob/master/R/rminiconda.R#L48). This of course was already a bug if the user had supplied a path with spaces.

if (file.access(mcpath, mode = 2) == 1) {
stop(
"Cannot access or create a suitable directory for local miniconda ",
"installtion. Please check the R_MINICONDA_PATH environment variable ",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spelling

@hafen
Copy link
Owner

hafen commented Oct 24, 2019

Just an update on this - the space in "Application Support" looks like it is an issue out of our control as the miniconda installer won't allow spaces in paths, which makes it difficult to work with rappdirs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants