Fixes for submission

hafen · Nov 29, 2023 · b2f25f9 · b2f25f9
1 parent 6da91cf
commit b2f25f9
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 14 deletions.
diff --git a/cran-comments.md b/cran-comments.md
@@ -4,14 +4,15 @@ New submission
 
 Package was archived on CRAN today
 
-- Updated to be compatible with ggplot2 updates
-- Added new grids
-- Changed vignette builder to pkgdown (no longer dependent on packagedocs)
+Updates since last release:
+
+- Fixed obscure issue with unicode characters in grid names on some linux systems that caused the package to be removed from CRAN
+- Updated package infrastructure to reflect latest CRAN policies, etc.
 
 ## Test environments
 
 * local OS X install, R 4.3.2
-* ubuntu 16.04 (on travis-ci), R 4.0.0
+* ubuntu 22.04.3 (on GitHub Actions), R 4.3.2
 * win-builder (devel and release)
 
 ## R CMD check results
@@ -20,4 +21,4 @@ Package was archived on CRAN today
 
 ## Reverse dependencies
 
-R CMD check ran successfully on the only reverse dependencies arcos and polAr.
+R CMD check ran successfully on the only reverse dependencies geoAr and geofi.
diff --git a/man-roxygen/ex-facet_geo.R b/man-roxygen/ex-facet_geo.R
@@ -162,7 +162,7 @@ ggplot(election, aes("", pct, fill = candidate)) +
   facet_geo(~ state, grid = "us_state_grid2") +
   scale_y_continuous(expand = c(0, 0)) +
   labs(title = "2016 Election Results",
-    caption = "Data Source: https://docs.google.com/spreadsheets/d/133Eb4qQmOxNvtesw2hdVns073R68EZx4SfCnP4IGQf8",
+    caption = "Data Source: 2016 National Popular Vote Tracker",
     x = NULL,
     y = "Percentage of Voters") +
   theme(axis.title.x = element_blank(),
@@ -177,7 +177,7 @@ ggplot(election, aes(candidate, pct, fill = candidate)) +
   theme_bw() +
   coord_flip() +
   labs(title = "2016 Election Results",
-    caption = "Data Source: https://docs.google.com/spreadsheets/d/133Eb4qQmOxNvtesw2hdVns073R68EZx4SfCnP4IGQf8",
+    caption = "Data Source: 2016 National Popular Vote Tracker",
     x = NULL,
     y = "Percentage of Voters") +
   theme(strip.text.x = element_text(size = 6))
@@ -188,7 +188,7 @@ ggplot(election, aes(candidate, votes / 1000000, fill = candidate)) +
   facet_geo(~ state, grid = "us_state_grid2") +
   coord_flip() +
   labs(title = "2016 Election Results",
-    caption = "Data Source: https://docs.google.com/spreadsheets/d/133Eb4qQmOxNvtesw2hdVns073R68EZx4SfCnP4IGQf8",
+    caption = "Data Source: 2016 National Popular Vote Tracker",
     x = NULL,
     y = "Votes (millions)") +
   theme(strip.text.x = element_text(size = 6))

diff --git a/man/facet_geo.Rd b/man/facet_geo.Rd
diff --git a/vignettes/geofacet.Rmd b/vignettes/geofacet.Rmd
@@ -254,7 +254,7 @@ ggplot(election, aes("", pct, fill = candidate)) +
   facet_geo(~ state, grid = "us_state_grid2") +
   scale_y_continuous(expand = c(0, 0)) +
   labs(title = "2016 Election Results",
-    caption = "Data Source: https://docs.google.com/spreadsheets/d/133Eb4qQmOxNvtesw2hdVns073R68EZx4SfCnP4IGQf8",
+    caption = "Data Source: 2016 National Popular Vote Tracker",
     x = NULL,
     y = "Percentage of Voters") +
   theme(axis.title.x = element_blank(),
@@ -271,7 +271,7 @@ ggplot(election, aes(candidate, pct, fill = candidate)) +
   theme_bw() +
   coord_flip() +
   labs(title = "2016 Election Results",
-    caption = "Data Source: https://docs.google.com/spreadsheets/d/133Eb4qQmOxNvtesw2hdVns073R68EZx4SfCnP4IGQf8",
+    caption = "Data Source: 2016 National Popular Vote Tracker",
     x = NULL,
     y = "Percentage of Voters") +
   theme(strip.text.x = element_text(size = 6))
@@ -284,7 +284,7 @@ ggplot(election, aes(candidate, votes / 1000000, fill = candidate)) +
   facet_geo(~ state, grid = "us_state_grid2") +
   coord_flip() +
   labs(title = "2016 Election Results",
-    caption = "Data Source: https://docs.google.com/spreadsheets/d/133Eb4qQmOxNvtesw2hdVns073R68EZx4SfCnP4IGQf8",
+    caption = "Data Source: 2016 National Popular Vote Tracker",
     x = NULL,
     y = "Votes (millions)") +
   theme(strip.text.x = element_text(size = 6))