Add serialize_in_event_loop=False for HA 2025.12.0+#4947
Draft
Add serialize_in_event_loop=False for HA 2025.12.0+#4947
Conversation
Co-authored-by: ludeeus <15093472+ludeeus@users.noreply.github.com>
Co-authored-by: ludeeus <15093472+ludeeus@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Set serialize_in_event_loop flag to false in HACSStore
Add serialize_in_event_loop=False for HA 2025.12.0+
Nov 26, 2025
ludeeus
requested changes
Nov 26, 2025
tests/utils/test_store.py
Outdated
Comment on lines
69
to
70
|
|
||
| async def test_serialize_in_event_loop_version_check(hass: HomeAssistant) -> None: |
Member
There was a problem hiding this comment.
@copilot Use parameterized tests that pass in 2 versions and a boolean value with the expected result.
Use unittest.patch to override the core version.
Author
There was a problem hiding this comment.
Implemented parameterized test with 5 version/expected pairs and unittest.patch in 24ffd7f.
Co-authored-by: ludeeus <15093472+ludeeus@users.noreply.github.com>
ludeeus
requested changes
Nov 26, 2025
| ("2026.1.0", True), | ||
| ], | ||
| ) | ||
| def test_serialize_in_event_loop_version_check(ha_version: str, expected_supported: bool) -> None: |
Co-authored-by: ludeeus <15093472+ludeeus@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
serialize_in_event_loop=Falseflag to HACSStore when running on HA 2025.12.0+custom_components/hacs/utils/store.pyto conditionally addserialize_in_event_loop=Falsefor HA 2025.12.0+_SERIALIZE_IN_EVENT_LOOP_SUPPORTEDwith mocked HA versionsOriginal prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.