Handle exceptions when parsing 'retry-after' header in rate limit handling#4931
Open
Handle exceptions when parsing 'retry-after' header in rate limit handling#4931
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request improves the robustness of rate limit handling in the async_download_file method by adding exception handling around the parsing of the retry-after HTTP header. When GitHub returns a 429 (rate limit) status, the code now safely handles cases where the retry-after header contains non-numeric values, preventing potential crashes and gracefully falling back to a 10-second default retry interval.
Key Changes
- Added try-except block to catch
ValueErrorandTypeErrorwhen parsing theretry-afterheader value - Maintains backward-compatible behavior with a sensible 10-second default on parsing errors
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a minor improvement to the rate-limit handling logic in the
async_download_filemethod. The change ensures that the value of theretry-afterheader is safely parsed, preventing potential errors if the header is missing or not an integer.retry-afterheader by adding atry...exceptblock to catch parsing errors, defaulting to 10 seconds if necessary incustom_components/hacs/base.py.