Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue with SQlite connection #1879

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Fix issue with SQlite connection #1879

wants to merge 4 commits into from

Conversation

alibell
Copy link

@alibell alibell commented Aug 8, 2024

The current docker image doesn't work with SQLite.

There are two main issues :

  • pcheck is executed even if the $CMD_DB_URL connection is configured to use an sqlite database
  • the sqlite3 node package is not installed by default

The current fix resolve these two issues.

yamashush and others added 3 commits August 8, 2024 10:47
@yamashush
Add index at revision table
9f16120 
Signed-off-by: yamashush <[email protected]>
Signed-off-by: Ali Bellamine <[email protected]>
@Yukaii
style: lint fix
280125c 
Signed-off-by: Yukai Huang <[email protected]>
Signed-off-by: Ali Bellamine <[email protected]>
Fix issue with SQlite connection
3ed5c4d 
Signed-off-by: Ali Bellamine <[email protected]>
Reduce npm install log
6c10551 
Signed-off-by: Ali Bellamine <[email protected]>
@Nexyll
Copy link

Nexyll commented Dec 11, 2024

I was wondering why a migration was created to add an index in this PR?
By the way, I’m very interested in the fix. Is the project still active?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alibell @Nexyll @yamashush @Yukaii