Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new config option allowVisibleSource #1621

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Add new config option allowVisibleSource #1621

wants to merge 4 commits into from
+145 −11

Conversation

roman-yatsenko
Copy link

Add new config option allowVisibleSource to the project. The default value for this option is true. The false value will block Edit and Both editor modes for users that have no rights to edit a note.

Pull request adds:

  • new config option allowVisibleSource with default value true;
  • new environment variable CMD_VISIBLE_SOURCE;
  • disable Edit and Both modes for users without edit note permission;
  • redirect form Edit and Both modes to View mode by direct URL with mode parameter.

@roman-yatsenko roman-yatsenko mentioned this pull request Nov 17, 2020
Closed
@Yukaii Yukaii requested a review from jackycute September 27, 2021 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackycute jackycute Awaiting requested review from jackycute

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@roman-yatsenko @JamesHow1ett