Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POC for using markdown-it-diagrams #1553

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

dmayle
Copy link

@dmayle dmayle commented Jul 8, 2020

This is a hacky POC showing the use of markdown-it-diagrams for mermaid
and svgbob. Notable changes:

  • Adds svgbob support for ascii diagrams
  • CDN config isn't tested because svgbob wasm isn't available via CDN
  • Mermaid doesn't show errors. Error code didn't work before removal.

This addresses issue #1549

This is a hacky POC showing the use of markdown-it-diagrams for mermaid
and svgbob.  Notable changes:

  * Adds svgbob support for ascii diagrams
  * CDN config isn't tested because svgbob wasm isn't available via CDN
  * Mermaid doesn't show errors.  Error code didn't work before removal.

Signed-off-by: Douglas Mayle <[email protected]>
@dmayle dmayle force-pushed the markdown-it-diagrams branch from a3e4d33 to e9e81b6 Compare July 8, 2020 13:49
@Yukaii Yukaii temporarily deployed to codimd-markdown-it-diag-wruofn July 9, 2020 02:44 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants