Open
Conversation
alx-alexpark
requested changes
Jul 29, 2025
Member
alx-alexpark
left a comment
alx-alexpark
left a comment
There was a problem hiding this comment.
Please add the trailing dot. Also waiting for confirmation of hq approval
Member
|
Following up on this, is this still needed? |
Co-authored-by: Alex Park <parkalex380@gmail.com>
Co-authored-by: Alex Park <parkalex380@gmail.com>
Contributor
Author
alx-alexpark
approved these changes
Sep 7, 2025
Member
alx-alexpark
left a comment
alx-alexpark
left a comment
There was a problem hiding this comment.
lgtm, but dns is currently broken so i'll merge whenever things get fixed
Member
|
Oh and also, please resolve conflicts I didn't see that |
Contributor
Author
|
i did... |
Member
|
Co-authored-by: Alex Park <parkalex380@gmail.com>
Co-authored-by: Alex Park <parkalex380@gmail.com>
Contributor
Author
|
done |
Comment on lines
-414
to
-416
| - vc-domain-verify=backend.arena.hackclub.com,079b94be7b001fa4e775 | ||
| - vc-domain-verify=arena.hackclub.com,18d51eef05279bd5822f | ||
| - vc-domain-verify=waffles.hackclub.com,04eb4de0bcc5369e4dca |
Member
There was a problem hiding this comment.
oops can you undo this as well i think overselected when i gave you the suggestion
Contributor
Author
There was a problem hiding this comment.
how do I undo 😭
Contributor
|
@pizzalover125 is this still needed? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding
enclosure.hackclub.comDescription
Enclosure is an upcoming YSWS about making cases. HQ sponsor is @jps.