Open
Conversation
Member
Author
|
It looks like the dry run passed with the |
Member
|
Is this intended to supersede #1129 ? |
Member
Author
|
Oops, I hadn't realized that there was already another PR open! Feel free to do whatever you'd like with this PR. I'll clean up the merge conflict in case anyone plans to merge this |
garyhtou
force-pushed
the
garyhtou/sort
branch
from
19c3de2 to
2f75845
Compare
``` Formatting hackclub.com.yaml hackclub.com.yaml | 512 +++++++++++++++++++++++++------------------------------ 1 file changed, 242 insertions(+), 270 deletions(-) Formatting hackclub.org.yaml hackclub.org.yaml | 43 +++++++++++++++++++++---------------------- 1 file changed, 21 insertions(+), 22 deletions(-) Formatting hackclub.io.yaml hackclub.io.yaml | 44 ++++++++++++++++++++++---------------------- 1 file changed, 22 insertions(+), 22 deletions(-) Formatting hackedu.us.yaml hackedu.us.yaml | 36 ++++++++++++++++++------------------ 1 file changed, 18 insertions(+), 18 deletions(-) Formatting hack.af.yaml hack.af.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Formatting bulckcah.com.yaml bulckcah.com.yaml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) Formatting dino.icu.yaml dino.icu.yaml | 378 +++++++++++++++++++++++------------------------------------ 1 file changed, 151 insertions(+), 227 deletions(-) Formatting dinosaurbbq.org.yaml dinosaurbbq.org.yaml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) Formatting hack.club.yaml Formatting hackclub.app.yaml hackclub.app.yaml | 64 +++++++++++++++++++++++++++---------------------------- 1 file changed, 32 insertions(+), 32 deletions(-) Formatting hackfoundation.org.yaml hackfoundation.org.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Formatting wackclub.com.yaml wackclub.com.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Formatting bank.engineering.yaml bank.engineering.yaml | 102 +++++++++++++++++++++++++-------------------------- 1 file changed, 51 insertions(+), 51 deletions(-) Formatting scrap.dev.yaml scrap.dev.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Formatting scrapbook.dev.yaml scrapbook.dev.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Formatting cpu.land.yaml cpu.land.yaml | 27 +++++++++++++-------------- 1 file changed, 13 insertions(+), 14 deletions(-) Formatting aisafety.dance.yaml aisafety.dance.yaml | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) Formatting nonprofit.new.yaml ```
garyhtou
force-pushed
the
garyhtou/sort
branch
from
2f75845 to
830716e
Compare
Member
|
I think the one thing this PR is missing is a check script that can be run with CI to make sure the format doesn't break through future PRs. If that happens I think this would be great :) |
Contributor
|
I already had that in my PR, but if there's a reason it wasn't merged I'm happy to make changes or turn this over to @garyhtou. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a
bin/formatscript that usesbashandyqto format & sort the YAML files.It first checks the zones in
config/production.yamlto see which files contain DNS declarations. Then, it usesyqto sort the keys and pretty print.The script also provides a small diffstat when ran.