Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config): serialization crash #97

Merged
merged 2 commits into from
Mar 7, 2023
Merged

Conversation

CAMOBAP
Copy link
Collaborator

@CAMOBAP CAMOBAP commented Mar 5, 2023

Troubleshooting details

Affected versions: >= 3.40

The issue was introduced in 3.4.0 (c636106)

@CAMOBAP CAMOBAP requested review from e271828- and DSergiu March 5, 2023 19:42
@CAMOBAP CAMOBAP self-assigned this Mar 5, 2023
@github-actions
Copy link

github-actions bot commented Mar 5, 2023

Diffuse report:

OLD: sdk-main.aar
NEW: sdk-pr.aar

 AAR      │ old       │ new       │ diff   
──────────┼───────────┼───────────┼────────
      jar │  47.4 KiB │  47.8 KiB │ +360 B 
 manifest │     457 B │     457 B │    0 B 
      res │  78.3 KiB │  78.3 KiB │    0 B 
    other │  75.6 KiB │  75.6 KiB │    0 B 
──────────┼───────────┼───────────┼────────
    total │ 201.8 KiB │ 202.1 KiB │ +360 B 

 JAR     │ old │ new │ diff         
─────────┼─────┼─────┼──────────────
 classes │  36 │  36 │   0 (+0 -0)  
 methods │ 449 │ 460 │ +11 (+12 -1) 
  fields │ 149 │ 149 │   0 (+0 -0)
AAR
 size     │ diff   │ path          
──────────┼────────┼───────────────
 47.8 KiB │ +360 B │ ∆ classes.jar 
──────────┼────────┼───────────────
 47.8 KiB │ +360 B │ (total)
JAR
METHODS:

   old │ new │ diff         
  ─────┼─────┼──────────────
   449 │ 460 │ +11 (+12 -1) 
  + com.hcaptcha.sdk.HCaptchaConfig _deserializeLambda_(SerializedLambda) → Object
  + com.hcaptcha.sdk.HCaptchaConfig lambda__default_retryPredicate_41a513e9_1(HCaptchaConfig, HCaptchaException) → boolean
  + java.lang.IllegalArgumentException <init>(String)
  + java.lang.Object getClass() → Class
  + java.lang.invoke.LambdaMetafactory altMetafactory(MethodHandles_Lookup, String, MethodType, Object[]) → CallSite
  + java.lang.invoke.SerializedLambda getFunctionalInterfaceClass() → String
  + java.lang.invoke.SerializedLambda getFunctionalInterfaceMethodName() → String
  + java.lang.invoke.SerializedLambda getFunctionalInterfaceMethodSignature() → String
  + java.lang.invoke.SerializedLambda getImplClass() → String
  + java.lang.invoke.SerializedLambda getImplMethodKind() → int
  + java.lang.invoke.SerializedLambda getImplMethodName() → String
  + java.lang.invoke.SerializedLambda getImplMethodSignature() → String
  
  - com.hcaptcha.sdk.HCaptchaConfig lambda__default_retryPredicate_0(HCaptchaConfig, HCaptchaException) → boolean

@e271828-
Copy link
Contributor

e271828- commented Mar 5, 2023

@CAMOBAP looks good, please update CHANGES + bump version.

@DSergiu DSergiu changed the title bugfix: HCaptchaConfig serialization crash #94 fix(config): serialization crash #94 Mar 6, 2023
@DSergiu DSergiu changed the title fix(config): serialization crash #94 fix(config): serialization crash Mar 6, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@CAMOBAP
Copy link
Collaborator Author

CAMOBAP commented Mar 7, 2023

@CAMOBAP looks good, please update CHANGES + bump version.

Done, @e271828- @DSergiu could you please review

@DSergiu DSergiu merged commit f2498b5 into main Mar 7, 2023
@DSergiu DSergiu deleted the bugfix/config-serialization branch March 7, 2023 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants