Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sonarqube issues #164

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

fix: sonarqube issues #164

wants to merge 4 commits into from

Conversation

CAMOBAP
Copy link
Collaborator

@CAMOBAP CAMOBAP commented Jul 22, 2024

No description provided.

@CAMOBAP CAMOBAP self-assigned this Jul 22, 2024
Copy link

sonarcloud bot commented Jul 22, 2024

Copy link

github-actions bot commented Jul 22, 2024

Diffuse report:

OLD: sdk-main.aar
NEW: sdk-pr.aar

 AAR      │ old       │ new       │ diff  
──────────┼───────────┼───────────┼───────
      jar │  51.7 KiB │  51.7 KiB │ -42 B 
 manifest │     411 B │     411 B │   0 B 
      res │  78.3 KiB │  78.3 KiB │   0 B 
    other │     954 B │     954 B │   0 B 
──────────┼───────────┼───────────┼───────
    total │ 131.3 KiB │ 131.3 KiB │ -42 B 

 JAR     │ old │ new │ diff       
─────────┼─────┼─────┼────────────
 classes │  37 │  37 │  0 (+0 -0) 
 methods │ 507 │ 507 │  0 (+0 -0) 
  fields │ 162 │ 163 │ +1 (+1 -0)
AAR
 size     │ diff  │ path          
──────────┼───────┼───────────────
 51.7 KiB │ -42 B │ ∆ classes.jar 
──────────┼───────┼───────────────
 51.7 KiB │ -42 B │ (total)
JAR
FIELDS:

   old │ new │ diff       
  ─────┼─────┼────────────
   162 │ 163 │ +1 (+1 -0) 
  
  + com.hcaptcha.sdk.HCaptchaDebugInfo MAX_ENTRIES: int

Copy link

github-actions bot commented Jul 22, 2024

Benchmark report:

Test name Time ms. (median) Allocations (median)
com.hcaptcha.sdk.HCaptchaBenchmarkTest.EMULATOR_UNLOCKED_benchmarkInvisibleVerification +327.01 -6
com.hcaptcha.sdk.HCaptchaBenchmarkTest.EMULATOR_UNLOCKED_benchmarkInvisibleVerificationColdRun +418.42 +99
com.hcaptcha.sdk.HCaptchaBenchmarkTest.EMULATOR_UNLOCKED_benchmarkInvisibleSetup +1.15 +96
com.hcaptcha.sdk.HCaptchaDebugInfoTest.EMULATOR_UNLOCKED_benchmarkDebugInfo -17.30 -5642
com.hcaptcha.sdk.HCaptchaDebugInfoTest.EMULATOR_UNLOCKED_benchmarkDebugSys +17.14 +1

@DSergiu DSergiu changed the title Chore/sonarqube issues fix: sonarqube issues Jul 29, 2024
@CAMOBAP CAMOBAP force-pushed the chore/sonarqube-issues branch from 44a1e46 to 088ec71 Compare August 23, 2024 17:11
Copy link

sonarcloud bot commented Aug 23, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant