Meson subproject sample test control #78
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some user may want to use test suite in their builds.
piotrrak
commented
Sep 24, 2020
| if not meson.is_subproject() | ||
| subdir('src') | ||
| subdir('src') | ||
| subdir('example/api2-samples') |
There was a problem hiding this comment.
This currently has slight semantic difference, since meson will be visiting 'example/api2-samples' subdirectory, it will be created in build directory when using non flat layout. Dunno if this mkdir is a concern, or not, but guess I should mention it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello
Currently when using as this library meson subproject I have no control over on weather tests and samples are built.
The first change bumps required meson version to 0.54.0 (ffmpeg on
meson-4.3branch already requires it). This let me remove check formeson.override_dependency()and use 0.53.0 prettysummary().Second change leaves defaults as they were - when built as subproject it defaults to no tests and samples.
While now I can specify
-Davcpp:build_tests=truein my master project to adjust it to my likeing.