Fix missing stats when migrating from 1.13.0 to 1.14.x #937
+1,435
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! I noticed that when I upgraded from 1.13.0 to 1.14.4 earlier today, the statistics and charts for completed experiments were blank. In order to fix that, I re-added sqlitedict as a dependency and added a short migration step from sqlitedict to diskcache. Additionally, I noticed that when I tried to run uv on this repo, it gave me an error because my pyenv version is 3.12.3 but this repo only allowed 3.10.x. I have run this codebase, including normal training, grid search, and most of the features, on 3.11.9 and 3.12.3 successfully without any issues. I've tested it on Ubuntu 22.04 and Linux Mint 22.1 (based on Ubuntu 24.04). I don't have access to any Windows or Mac machines, otherwise I'd have tested on those, however there shouldn't be any issues with only slightly loosening the CPython version requirements. 3.13 and 3.14 have a bunch of weird changes with the C-API and aren't widely supported, but <=3.12 is quite widely supported so it should help the popularity of this project if we let more versions install it.