Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added units (ms) in comments to RTT stats #461

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Added units (ms) in comments to RTT stats #461

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
500eb48
Added units (ms) in comments to RTT stats
maxsharabayko Jun 8, 2021
45b16aa
Using '-'
maxsharabayko Jun 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions include/quicly/loss.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,24 +71,24 @@ typedef struct quicly_loss_conf_t {

/**
* Holds RTT variables. We use this structure differently from the specification:
* * if the first sample has been obtained should be checked by doing: `latest != 0`
* * smoothed and variance are avaiable even before the first RTT sample is obtained
* - if the first sample has been obtained should be checked by doing: `latest != 0`
* - smoothed and variance are avaiable even before the first RTT sample is obtained.
*/
typedef struct quicly_rtt_t {
/**
* Minimum RTT value, measured over the entire connection.
* Minimum RTT value (ms), measured over the entire connection.
*/
uint32_t minimum;
/**
* Current smoothed RTT value.
* Current smoothed RTT value (ms).
*/
uint32_t smoothed;
/**
* Current estimate of RTT variance.
* Current estimate of RTT variance (ms).
*/
uint32_t variance;
/**
* Value of the latest RTT sample.
* Value of the latest RTT sample (ms).
*/
uint32_t latest;
} quicly_rtt_t;
Expand Down