Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding bioentity endpoints #185

Merged
merged 5 commits into from
Oct 29, 2024
Merged

Adding bioentity endpoints #185

merged 5 commits into from
Oct 29, 2024

Conversation

pnavada
Copy link
Contributor

@pnavada pnavada commented Oct 6, 2024

Added New Endpoints for Querying Bioentity Information

Files added/modified:

  1. indra_cogex/apps/bioentity/api.py – Contains the newly defined endpoints for querying bioentity information.
  2. indra_cogex/apps/queries_web/__init__.py – Created query_ns using flask_restx.Namespace instead of api. Defined query_model from query_ns instead of api.
  3. indra_cogex/apps/rest_api.py – Created this file to define the api and added both bioentity_ns and query_ns to it.
  4. indra_cogex/apps/wsgi.py – Now imports api from apps/rest_api.py instead of queries_web.__init__.py.

This PR also updates url_for calls in the home.html template, superseding #184.

@kkaris
Copy link
Collaborator

kkaris commented Oct 7, 2024

I tried out the code quickly locally and what I checked out looked good.

A couple of things:

  • The code needs to be rebased on the latest main
  • Add description of what this PR does: which files are changes and for what purpose they were changed (i.e., add new endpoints, what they do, etc..)

@kkaris
Copy link
Collaborator

kkaris commented Oct 7, 2024

Also, make sure that the queries web module isn't affected by this PR by trying out some of the endpoints

@pnavada
Copy link
Contributor Author

pnavada commented Oct 12, 2024

(.venv) navada@Pruthvis-MBP bioentity % git rebase main
Current branch develop is up to date.

Rebasing looks fine to me. The branch seems to be upto date with the latest main changes

@pnavada
Copy link
Contributor Author

pnavada commented Oct 12, 2024

Added the file changes to the PR description

@pnavada
Copy link
Contributor Author

pnavada commented Oct 12, 2024

Added separate models for each biomolecule entity (kinase, phosphatase, and transcription factor) to include distinct examples.

@kkaris
Copy link
Collaborator

kkaris commented Oct 15, 2024

Rebasing looks fine to me. The branch seems to be up to date with the latest main changes

Did you fetch the latest updates from gyorilab? I think your main branch might be out of sync with gyorilab/main.

@kkaris
Copy link
Collaborator

kkaris commented Oct 22, 2024

I rebased on the latest main on gyorilab and did some formatting updates. A commit from another PR is tagging along here as well. Rebased on main again after #184 was merged.

@kkaris kkaris self-requested a review October 22, 2024 22:52
@kkaris kkaris assigned kkaris and pnavada and unassigned kkaris Oct 22, 2024
Copy link
Collaborator

@kkaris kkaris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@bgyori bgyori merged commit 767713b into gyorilab:main Oct 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants