-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding bioentity endpoints #185
Conversation
I tried out the code quickly locally and what I checked out looked good. A couple of things:
|
Also, make sure that the queries web module isn't affected by this PR by trying out some of the endpoints |
(.venv) navada@Pruthvis-MBP bioentity % git rebase main Rebasing looks fine to me. The branch seems to be upto date with the latest main changes |
Added the file changes to the PR description |
Added separate models for each biomolecule entity (kinase, phosphatase, and transcription factor) to include distinct examples. |
Did you fetch the latest updates from gyorilab? I think your |
I rebased on the latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Added New Endpoints for Querying Bioentity Information
Files added/modified:
indra_cogex/apps/bioentity/api.py
– Contains the newly defined endpoints for querying bioentity information.indra_cogex/apps/queries_web/__init__.py
– Createdquery_ns
usingflask_restx.Namespace
instead of api. Definedquery_model
fromquery_ns
instead of api.indra_cogex/apps/rest_api.py
– Created this file to define the api and added bothbioentity_ns
andquery_ns
to it.indra_cogex/apps/wsgi.py
– Now imports api fromapps/rest_api.py instead of queries_web.__init__.py
.This PR also updates
url_for
calls in thehome.html
template, superseding #184.