Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

round temperature to nearest whole number #199

Merged
merged 3 commits into from
May 25, 2018

Conversation

M0nica
Copy link
Contributor

@M0nica M0nica commented Apr 19, 2018

##Issue Number: #101

Description

Added Math.round() to weather to make sure that it is rounded to the nearest whole number

##Do any new issues need to be created as a result of this PR"?

No.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

🚨Please review the contribution guidelines to this repository.

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • Created a new branch from 'dev' and PR is targeting the project's 'dev' branch.
  • The issue can be closed.

Provide a descriptive branch name and once the pull request is approved and merged to dev, the branch can be deleted.

💔Thank you!

Copy link
Collaborator

@digilou digilou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears to have conflicts in the Header.js...?

@M0nica
Copy link
Contributor Author

M0nica commented May 16, 2018

@digilou @sgluzins Can you please review to see if it is able to merge now? I attempted to resolve the merge conflict.

@M0nica M0nica merged commit 9b2e3bd into gwg-women:dev May 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants