Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update main.tf #138

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update main.tf #138

wants to merge 1 commit into from

Conversation

guy-suli
Copy link
Owner

No description provided.

Copy link

@bridgecrew bridgecrew bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bridgecrew has found 3 infrastructure configuration errors in this PR ⬇️

@@ -1,17 +1,20 @@
resource "aws_kms_key" "a" {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error Description: Ensure rotation for customer created CMKs is enabled
Category: Logging | Severity: CRITICAL
Resource: aws_kms_key [a], lines: 1 - 5

@@ -1,17 +1,20 @@
resource "aws_kms_key" "a" {
description = "KMS key 1"
deletion_window_in_days = 10

}

resource "aws_kms_key" "b" {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error Description: Ensure rotation for customer created CMKs is enabled
Category: Logging | Severity: CRITICAL
Resource: aws_kms_key [b], lines: 7 - 11

}

resource "aws_kms_key" "b" {
description = "KMS key 1"
deletion_window_in_days = 10

}


resource "aws_kms_key" "c" {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error Description: Ensure rotation for customer created CMKs is enabled
Category: Logging | Severity: CRITICAL
Resource: aws_kms_key [c], lines: 14 - 18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant