Support response payload serializer for views #163
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phantran
changed the title
phantran
force-pushed
the
improvement/add-serializer-for-response-payload
branch
3 times, most recently
from
e388f54 to
fdbec1d
Compare
phantran
force-pushed
the
improvement/add-serializer-for-response-payload
branch
from
876732a to
8951af9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Introducing a response payload serializer to validate and serialize response payload.
What issue does this solve?
#162 Support for using separate serializers for the request and response payloads in views. This would allow us to ensure that the data is properly serialized and deserialized in both directions. When combining this feature with the no model view, we can support compute API endpoints.
Where should the reviewer start?
Starting at
AbstractBaseAPIwhere the new attributeresponse_serializeris declared, then go torender_to_responsemethod inAPIResponseclass whereresponse_serializeris conditionally used if it's defined. The methodserialize_responseinSerializeModelsis where the serialization is performedWhat Worf gif best describes this PR or how it makes you feel?
https://i.gifer.com/HHsI.gif
Checklist
READMEupdates reflecting any new features/improvements to the framework