Update validate group argument to options object#63
Open
ricardogama wants to merge 1 commit intoguillaumepotier:masterfrom
Open
Update validate group argument to options object#63ricardogama wants to merge 1 commit intoguillaumepotier:masterfrom
ricardogama wants to merge 1 commit intoguillaumepotier:masterfrom
Conversation
8288280 to
bebac1a
Compare
bebac1a to
ad34122
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the last
groupargument ofValidator.validatemethod to be an options object. To validate with assertion groups, thegroupoption can be provided on theoptionsargument:This is a breaking change but will enable adding more optional features in a scalable manner, as the ones proposed on #60 and #61.