Rewrite running on AWS EC2 instance #4272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilija-lazoroski
force-pushed
the
4209-aws-run-on-ec2-machine-feature
branch
from
60aa6a5
to
83b4f00
Compare
ilija-lazoroski
force-pushed
the
4209-aws-run-on-ec2-machine-feature
branch
3 times, most recently
from
e3d1354
to
ab38708
Compare
mssalvatore
reviewed
Aug 12, 2024
docs/content/features/run_on_aws.md
Outdated
Comment on lines
20
to
22
| This feature lets you run Infection Monkey Agent on your chosen EC2 | ||
| instances without the requirement of manual installation, enabling the simulation of | ||
| various attack scenarios across your AWS infrastructure. |
There was a problem hiding this comment.
- "This feature" is somewhat ambiguous after reading the previous paragraph. What feature? The Amazon Message Delivery Service?
- This standalone sentence should either have some supporting sentences or, itself, be a supporting sentence for something else.
Maybe we need a better/clearer name for this feature. It would improve some of the language in this doc.
mssalvatore
reviewed
Aug 12, 2024
docs/content/features/run_on_aws.md
Outdated
Comment on lines
11
to
18
| The Infection Monkey can run on AWS EC2 instances using the | ||
| [AWS Systems Manager (SSM) Agent]( | ||
| https://docs.aws.amazon.com/systems-manager/latest/userguide/what-is-systems-manager.html). | ||
| Each EC2 instance has an [SSM Agent]( | ||
| https://docs.aws.amazon.com/systems-manager/latest/userguide/ssm-agent.html) | ||
| installed for updating, managing, and configuring the instance. | ||
| It executes requests received from the AWS Systems Manager, and uses the Amazon | ||
| Message Delivery Service to report back status and execution details. |
There was a problem hiding this comment.
This context is fantastic. Should we add links for AWS Systems Manager and AMDS? Or are they not important?
mssalvatore
reviewed
Aug 12, 2024
docs/content/features/run_on_aws.md
Outdated
| instances without the requirement of manual installation, enabling the simulation of | ||
| various attack scenarios across your AWS infrastructure. | ||
|
|
||
| EC2 instances must be configured with the SSM Agent and the necessary IAM roles |
There was a problem hiding this comment.
Suggested change
| EC2 instances must be configured with the SSM Agent and the necessary IAM roles | |
| In order to launch Infection Monkey Agents using the AWS SSM Agent, EC2 instances must be configured with the SSM Agent and the necessary IAM roles |
What does it mean for an EC2 instance to be "configured with the SSM Agent". Do they need to "enable the SSM Agent on the EC2 instance?" Can we link to AWS's documentation that explains what steps they need to take?
Maybe we need a better/clearer name for this feature. It would improve some of the language in this doc.
There was a problem hiding this comment.
There can be instances that don't have SSM Agent preinstalled. I may need to reword this a bit.
It will be definitely easier to have a concise name for the feature. Maybe "Infection Monkey AWS Execution" ?
ilija-lazoroski
force-pushed
the
4209-aws-run-on-ec2-machine-feature
branch
2 times, most recently
from
c221bb6
to
a6292e8
Compare
shreyamalviya
requested changes
Aug 13, 2024
ilija-lazoroski
force-pushed
the
4209-aws-run-on-ec2-machine-feature
branch
from
a6292e8
to
046b505
Compare
shreyamalviya
requested changes
Aug 13, 2024
shreyamalviya
requested changes
Aug 13, 2024
ilija-lazoroski
force-pushed
the
4209-aws-run-on-ec2-machine-feature
branch
2 times, most recently
from
a1f50e9
to
362471f
Compare
ilija-lazoroski
force-pushed
the
4209-aws-run-on-ec2-machine-feature
branch
from
362471f
to
e87d30d
Compare
ilija-lazoroski
force-pushed
the
4209-aws-run-on-ec2-machine-feature
branch
from
e87d30d
to
03ee861
Compare
shreyamalviya
approved these changes
Aug 13, 2024
mssalvatore
reviewed
Aug 13, 2024
docs/content/features/run_on_aws.md
Outdated
Comment on lines
27
to
30
| 1. Ensure that the SSM Agent is installed on the EC2 instance on which | ||
| Infection Monkey will run. | ||
| 1. Ensure that the EC2 instance has the necessary IAM roles to allow | ||
| the SSM Agent to execute commands. |
There was a problem hiding this comment.
This starts to feel like a "how to".
mssalvatore
force-pushed
the
4209-aws-run-on-ec2-machine-feature
branch
from
636b3a7
to
cc07e43
Compare
mssalvatore
force-pushed
the
4209-aws-run-on-ec2-machine-feature
branch
from
cc07e43
to
585cf13
Compare
mssalvatore
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Issue #4209 .
Add any further explanations here.
PR Checklist
Testing Checklist