Fixed missing double empty line after foundValue in GetValueFromReadme. #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original idea seems to be to find the end of the string, so I did it using strchr, the code before this commit is overflowing the length, because it will add the entire string length counting twice the position, it could be the initial string pointer plus the entire string length "readmeContents + strlen(readmeContents)" or current pointer position plus the length of the current position "foundValue + strlen(foundValue)", but not both. Without this commit, it may fail depending on the CryptStringToBinaryA behavior when it encounters the string terminator before the length as it is not a valid base64 character.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original idea seems to be to find the end of the string, so I did it using strchr,
the code before this commit is overflowing the length, because it will add the entire
string length counting twice the position, it could be the initial string pointer plus
the entire string length "readmeContents + strlen(readmeContents)" or current pointer
position plus the length of the current position "foundValue + strlen(foundValue)",
but not both.
Without this commit, it may fail depending on the CryptStringToBinaryA behavior when it
encounters the string terminator before the length as it is not a valid base64 character.